Re: [Libreoffice] [REVIEW] Fix for fdo#37387

2011/5/21 Jean-Baptiste Faure <jbf.faure@orange.fr>:
> Le 20/05/2011 19:27, Andras Timar a écrit :
> > 2011/5/20 Cedric Bosdonnat <cedric.bosdonnat.ooo@free.fr>:
> > > Hi all,
> > >
> > > I just fixed some UI problem with CTL. Could you please review the fix,
> > > sign it off and push it?
> > >
> > > The problem that may appear here is that I needed to reduce the
> > > available space for some strings. I'm not sure it fits for all locales
> > > thought it should be OK.
> >
> > +1 for 3-4, I pushed your patch with small modifications. Strings were
> > truncated in my favourite locale, so I had to play with the X
> > coordinates a bit.
>
> The listbox "Style" is a little too short for French string "- aucun(e)
> -" ("- none -" in English) : truncated on the right parenthesis.
>
> I suggest, in sw/source/ui/frmdlg/column.src, to increase the size of
> ListBox LB_STYLE and MetricField ED_LINEWIDTH from 35 to 40 and to shift
> right by 5 units the six other objects accordingly.
>
> Here is a patch which do that.

I pushed your patch to 3-4. I looks better on the few locales I tested.
We need two more reviews for 3-4-0 for
http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4&id=335cc3bb837a671b3d6644bf9b4bc13a116102da
and
http://cgit.freedesktop.org/libreoffice/writer/commit/?h=libreoffice-3-4&id=27875f65e2c1953fbf636af32556833c44849f53

Thanks,
Andras