Re: [Libreoffice] [REVIEW] Fix for fdo#37387

Le 20/05/2011 19:27, Andras Timar a écrit :
> 2011/5/20 Cedric Bosdonnat <cedric.bosdonnat.ooo@free.fr>:
> > Hi all,
> >
> > I just fixed some UI problem with CTL. Could you please review the fix,
> > sign it off and push it?
> >
> > The problem that may appear here is that I needed to reduce the
> > available space for some strings. I'm not sure it fits for all locales
> > thought it should be OK.
>
> +1 for 3-4, I pushed your patch with small modifications. Strings were
> truncated in my favourite locale, so I had to play with the X
> coordinates a bit.

The listbox "Style" is a little too short for French string "- aucun(e)
-" ("- none -" in English) : truncated on the right parenthesis.

I suggest, in sw/source/ui/frmdlg/column.src, to increase the size of
ListBox LB_STYLE and MetricField ED_LINEWIDTH from 35 to 40 and to shift
right by 5 units the six other objects accordingly.

Here is a patch which do that.

Best regards
JBF

-- 
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.

From 826181a51821fa80da0bf35b27b8634162aa8154 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Faure <jbf.faure@orange.fr>
Date: Sat, 21 May 2011 18:05:49 +0200
Subject: [PATCH] give more room to style listbox

the size of ListBox LB_STYLE and MetricField ED_LINEWIDTH has been increased from 35 to 40
six other objects have been moved by 5 units accordingly
---
 sw/source/ui/frmdlg/column.src |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/sw/source/ui/frmdlg/column.src b/sw/source/ui/frmdlg/column.src
index 27e28d7..0601cd1 100644
--- a/sw/source/ui/frmdlg/column.src
+++ b/sw/source/ui/frmdlg/column.src
@@ -269,7 +269,7 @@ TabPage TP_COLUMN
     {
         HelpID = "sw:ListBox:TP_COLUMN:LB_STYLE";
         Pos = MAP_APPFONT ( 45 , 154 ) ;
-        Size = MAP_APPFONT ( 35 , 66 ) ;
+        Size = MAP_APPFONT ( 40 , 66 ) ;
         TabStop = TRUE ;
         DropDown = TRUE ;
     };
@@ -284,7 +284,7 @@ TabPage TP_COLUMN
     {
         Border = TRUE ;
         Pos = MAP_APPFONT ( 45 , 170 ) ;
-        Size = MAP_APPFONT ( 35 , 12 ) ;
+        Size = MAP_APPFONT ( 40 , 12 ) ;
         TabStop = TRUE ;
         Spin = TRUE ;
         Repeat = TRUE ;
@@ -298,7 +298,7 @@ TabPage TP_COLUMN
     };
     FixedText FT_COLOR
     {
-        Pos = MAP_APPFONT ( 160 , 156 ) ;
+        Pos = MAP_APPFONT ( 165 , 156 ) ;
         Size = MAP_APPFONT ( 25 , 8 ) ;
         Text [ en-US ] = "~Color" ;
         Left = TRUE ;
@@ -306,7 +306,7 @@ TabPage TP_COLUMN
     ListBox LB_COLOR
     {
         Border = TRUE ;
-        Pos = MAP_APPFONT ( 188 , 154 ) ;
+        Pos = MAP_APPFONT ( 193 , 154 ) ;
         Size = MAP_APPFONT ( 60 , 68 ) ;
         DropDown = TRUE ;
         DDExtraWidth = TRUE ;
@@ -314,7 +314,7 @@ TabPage TP_COLUMN
     };
     FixedText FT_HEIGHT
     {
-        Pos = MAP_APPFONT ( 86 , 156 ) ;
+        Pos = MAP_APPFONT ( 91 , 156 ) ;
         Size = MAP_APPFONT ( 30 , 8 ) ;
         Text [ en-US ] = "H~eight" ;
         Left = TRUE ;
@@ -323,7 +323,7 @@ TabPage TP_COLUMN
     {
         HelpID = "sw:MetricField:TP_COLUMN:ED_HEIGHT";
         Border = TRUE ;
-        Pos = MAP_APPFONT ( 119 , 154 ) ;
+        Pos = MAP_APPFONT ( 124 , 154 ) ;
         Size = MAP_APPFONT ( 35 , 12 ) ;
         TabStop = TRUE ;
         Left = TRUE ;
@@ -339,7 +339,7 @@ TabPage TP_COLUMN
     };
     FixedText FT_POSITION
     {
-        Pos = MAP_APPFONT ( 86 , 172 ) ;
+        Pos = MAP_APPFONT ( 91 , 172 ) ;
         Size = MAP_APPFONT ( 30 , 8 ) ;
         Left = TRUE ;
         Text [ en-US ] = "~Position" ;
@@ -347,7 +347,7 @@ TabPage TP_COLUMN
     ListBox LB_POSITION
     {
         HelpID = "sw:ListBox:TP_COLUMN:LB_POSITION";
-        Pos = MAP_APPFONT ( 119 , 170 ) ;
+        Pos = MAP_APPFONT ( 124 , 170 ) ;
         Size = MAP_APPFONT ( 35 , 40 ) ;
         TabStop = TRUE ;
         DropDown = TRUE ;
-- 
1.7.0.4