Hi Christian,
On Tue, 2011-05-10 at 23:25 +0200, Christian Lohmaier wrote:
It uses SvStream, and also has the stream set to little endian, but
then doesn't make use of the SvStream's read operations (that would
take care of bigendian → littleendian conversion, but manually reads
;-)
// wrong - you'll read it to big-endian machine, so
pStream->Read(&nTag, sizeof(nTag));
..
If the code used
*pStream >> nTag;
instead, the comparison would result in the correct result.
can we commit that at least - and then turn off the test for big-endian
machines ? [ in the absence of more PPCs around that seems like it might
be the easiest approach ].
ATB,
Michael.
--
michael.meeks@novell.com <><, Pseudo Engineer, itinerant idiot
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.