Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index



On Sun, 2011-05-08 at 15:09 +0200, Julien Nabet wrote:
I found this with cppcheck :
[vcl/unx/source/gdi/salbmp.cxx:795]: (style) Variable 'bFreePixmap' is 
not assigned a value

        Ho hum - I beg to differ:

        bool bFreePixmap = false;
        if( bSuccess && (args[0] >>= bFreePixmap) && bFreePixmap )

        Surely we assign it a value with the >>= operator ? true - it is not a
particularly pleasant use of the operator - but hey - UNO is like that
(sexy huh?). Why have:

        any.isBoolean() && any.asBoolean()

        or something - when we can have some mind-mashed operator, and a
confusing temporary ;-)

        Or did I miss something ? presumably another cppcheck false-positive
that needs filing & fixing (?).

        Thanks,

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.