Re: [Libreoffice] Compilation failed in vcl module (warning treated as errors)

Hi Mikos/Joseph,

I met a similar problem when:

$ cd tail_build
$ make -r

...

bootstrap/sw/source/filter/ww1/w1filter.cxx: In member function ‘void Ww1Picture::Out(Ww1Shell&, 
Ww1Manager&)’:
bootstrap/sw/source/filter/ww1/w1filter.cxx:1914: error: ‘class GDIMetaFile’ has no member named 
‘GetActionCount’
bootstrap/solver/300/unxlngi6.pro/workdir/CxxObject/sw/source/filter/ww1/w1filter.o] Error 1


On Wed, May 11, 2011 at 03:36:47AM +0200, Miklos Vajna wrote:
> On Tue, May 10, 2011 at 11:20:05PM +0200, Julien Nabet <serval2412@yahoo.fr> wrote:
> > Compiling: vcl/source/gdi/gdimtf.cxx
> > /home/maryline/compile-libreoffice/libo/clone/libs-gui/vcl/source/gdi/gdimtf.cxx:296:13: 
> > error: prototype for 'MetaAction* 
> > GDIMetaFile::ReplaceAction(MetaAction*, size_t)' does not match any in 
> > class 'GDIMetaFile'
> > ../../inc/vcl/gdimtf.hxx:218:21: error: candidate is: MetaAction* 
> > GDIMetaFile::ReplaceAction(MetaAction*, sal_uLong)
>
> (...)
>
> > Since I didn't fully understand how and when to use "sal_uLong" and 
> > "size_t"  + their implementation with 32/64 bits, I don't know how to 
> > fix this.
>
> Looks like Joseph started to replace sal_uLong by size_t, but he did not
> lave the prototypes / implementations in sync, see commit 6fb23043.
>
> I wonder how did this even build for him. ;)
>
> Norbert already fixed a few, issues, I've fixed
> GDIMetaFile::ReplaceAction() header, GDIMetaFile::Play() implementation
> and GDIMetaFile::GetActionPos() implmenentation, now it at least builds
> here.
>
> > By the way, couldn't it be useful to use --enable-werror by default ?
>
> See here:
> http://blog.flameeyes.eu/2009/02/25/future-proof-your-code-dont-use-werror
>
> Of course I have no problem with enabling werror by default when
> building from git, but doing it in release tarballs sounds odd.



> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


-- 
  Yifan Jiang
  Libreoffice
  Contact: yifan - irc.freenode.net/libreoffice
  =============================================  
  http://www.libreoffice.org/
  http://www.documentfoundation.org/