On Tue, May 10, 2011 at 11:20:05PM +0200, Julien Nabet <serval2412@yahoo.fr> wrote:
Compiling: vcl/source/gdi/gdimtf.cxx /home/maryline/compile-libreoffice/libo/clone/libs-gui/vcl/source/gdi/gdimtf.cxx:296:13: error: prototype for 'MetaAction* GDIMetaFile::ReplaceAction(MetaAction*, size_t)' does not match any in class 'GDIMetaFile' ../../inc/vcl/gdimtf.hxx:218:21: error: candidate is: MetaAction* GDIMetaFile::ReplaceAction(MetaAction*, sal_uLong)
(...)
Since I didn't fully understand how and when to use "sal_uLong" and "size_t" + their implementation with 32/64 bits, I don't know how to fix this.
Looks like Joseph started to replace sal_uLong by size_t, but he did not lave the prototypes / implementations in sync, see commit 6fb23043. I wonder how did this even build for him. ;) Norbert already fixed a few, issues, I've fixed GDIMetaFile::ReplaceAction() header, GDIMetaFile::Play() implementation and GDIMetaFile::GetActionPos() implmenentation, now it at least builds here.
By the way, couldn't it be useful to use --enable-werror by default ?
See here: http://blog.flameeyes.eu/2009/02/25/future-proof-your-code-dont-use-werror Of course I have no problem with enabling werror by default when building from git, but doing it in release tarballs sounds odd.
Attachment:
pgpJp0i5gh6iw.pgp
Description: PGP signature