Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi,

there are two slightly different implementations of SwDoc::SplitDoc(), depending on the third parameter given. As far as I can see they only differ in the way pSttNd (what stands Stt for?) and pEndNd are found. If that's true, I'd suggest to have two different GetEndNode() and GetSttNode() methods and only one

SplitDoc(sal_uInt16 eDocType, const String& rPath, const SwTxtFmtColl* pSplitColl, int nOutlineLevel)

with either pSplitColl OR nOutlineLevel passed as parameter but not both. Would that be bad coding style? On the other hand, are ~200 lines of identical code good style? Any suggestions how to get rid of the duplicates else?

Christina

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.