Re: [Libreoffice] [PATCH] Introduce HideDisabledMenuItems style setting

Hi Christian!

Sorry, it seems that I'm still a bit confused about that issue ...

Am Mittwoch, den 27.04.2011, 11:13 +0000 schrieb Christian Dywan:
> Am 27.04.2011 13:01:36 schrieb Christoph Noack:
> > Just a small question ... do I get it right that the disabled menu items 
> > get hidden instead of being "grayed out"? Real interest: could you 
> > please explain what the rationale for the change is? As far as I know, 
> > there is currently no platform guideline that requires that (or even 
> > allows that) - but I might be wrong. 
>
> Yes, disabled becomes hidden effectively. That is *current* behaviour
> on all systems as far as I can tell, so I'm not introducing anything
> new, to make that clear.

Okay, then we really talk about those items in the application menu -
now being hidden instead of "grayed out" temporarily (during runtime).

> I explicitly want to change this for GTK+ because it is wrong
> behaviour.
>
> As far as I know, OS X and KDE are the only platforms doing this (I'll
> ignore Maemo). I don't know the exact guideline, I didn't find clear
> documentation 

Mac OS X Human Interface Guidelines
        Naming Menu Items: "When a menu item is unavailable—because it
        doesn’t apply to the selected object or to the selected object
        in its current state, or because nothing is selected, for
        example—the item should appear dimmed (gray) in the menu ..."
        
http://developer.apple.com/library/mac/#documentation/UserExperience/Conceptual/AppleHIGuidelines/XHIGMenus/XHIGMenus.html#//apple_ref/doc/uid/TP30000356-TP6

KDE User Interface Guidelines
        "Menu items should not be added or removed during runtime.
        Disable or enable them instead."
        http://developer.kde.org/documentation/standards/kde/style/menus/index.html

GNOME Human Interface Guidelines
        4.3.2.1. Command Items Guidelines: "Do not remove command items
        from the menu when they are unavailable, make them insensitive
        instead."
        http://developer.gnome.org/hig-book/2.91/menus-design.html.en

Microsoft User Experience Interaction Guidelines
        "Disable menu items that don't apply to the current context,
        instead of removing them. Doing so makes menu bar contents
        stable and easier to find."
        http://msdn.microsoft.com/en-us/library/aa511502.aspx#presentation


Is that the information you searched for?


> about it but for example the web page context menu on OS X does it and
> editor popups I saw in KDE.

In this case, context menus are a different matter - they hide elements
instead of removing them (or positively: only show what's available).

But we have other issues within our context menus that need to be fixed
(since 15 years or so *g*).

> That said, Lubos or anyone else, please correct me if my observation
> is wrong, I'll adapt the patch accordingly.

[...]

Regards,
Christoph

-- 
LibreOffice Design Team. Make it just work, and look great, too!
http://wiki.documentfoundation.org/Design