On Friday 22 of April 2011, Kohei Yoshida wrote:
Hi Lubos,
On Fri, 2011-04-22 at 15:36 +0200, Lubos Lunak wrote:
Hello,
could somebody review the attached patch for bnc#689116? When e.g.
Writer is not installed (which can happen with split rpms) and one tries
to open a text document, LO simply quits without saying anything.
Guessing from the surrounding code it's correct, but I'd prefer it to be
checked as I have no clue about LO UI string handling or error handling
(and I bow to the creativitity of whoever has created this complex error
handling system).
I'm not an expert of this code either, but your change looks reasonable.
So go for it. :-) To be honest I don't think any one of us is
particularly versed in this part of the code base since it's relatively
new.
Pushed.
--
Lubos Lunak
l.lunak@suse.cz
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.