Hi Michael & All,
Le 11/04/11 11:41, Michael Meeks a écrit :
[...]
on 3.4 build, I've a strange display bug on dialog boxes ScrollBar.
But finding bugs is good - particularly if we have patches to discuss -
do you think you could dig into these ?
Last week, my answer was "no". But this evening, after many printf, it's
"yes"
I've a patch who fixe this bug ;-)
My "printf()" traces in "scrbar.cxx", show me that
getNativeControlRegion return "sal_false" for CTRL_SCROLLBAR
And I've found a missing "returnVal = sal_True;" in
"salnativewidgets-gtk.cxx"
It's very strange than this line was deleted ! I try to find the origine
of this delete with "qgit" and "gitk". But I can't find it !
Best regard
Bob
From 4ca312d7c13a6f3f57ab2229201cad56b4c2d3f4 Mon Sep 17 00:00:00 2001
From: Robert Dargaud <libo@bobiciel.com>
Date: Wed, 20 Apr 2011 00:14:25 +0200
Subject: [PATCH] fix fdo#36399 - ScrollBar display bug on dialog boxes
---
vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
index e1d12ce..e073794 100644
--- a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
@@ -987,7 +987,7 @@ sal_Bool GtkSalGraphics::getNativeControlRegion( ControlType nType,
rNativeContentRegion.Right() = rNativeContentRegion.Left() + 1;
if (!rNativeContentRegion.GetHeight())
rNativeContentRegion.Bottom() = rNativeContentRegion.Top() + 1;
-
+ returnVal = sal_True;
}
if( (nType == CTRL_MENUBAR) && (nPart == PART_ENTIRE_CONTROL) )
{
--
1.7.1
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.