Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


On Wed, 2011-03-16 at 13:55 +0100, Xisco Faulí wrote:
Hello,

It's the first time I do it so I searched for previous commits  in
order to get a referent. i couldn't find any example for
String.AssignAscii so I replace it with OUStringBuffer.appendAscii.
First sorry for the delay in reviewing this, a colleague recently poked
me about this patch and even then I missed that mail until today :-(
So, I have pushed the commit, I omitted any hunks that modified the
signatures of ::Find or ::CreateObject methods as these are virtual
methods in some base classes and they generated ( rightly ) a stack load
of warnings relating to hiding of various functions. There were one or 2
minor buglets I noticed regarding assigning the string versus appending
the string. Hopefully I haven't made other mistakes as the patch didn't
apply very well at all on master ( and since we caused the delay in
reviewing it it seemed only fair to adapt it myself )

thanks for the nice patch
regards,
Noel


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.