Re: [Libreoffice] [PATCH] remove String with OUString

On Wed, 2011-03-16 at 13:55 +0100, Xisco Faulí wrote:
> Hello,
>
> It's the first time I do it so I searched for previous commits  in
> order to get a referent. i couldn't find any example for
> String.AssignAscii so I replace it with OUStringBuffer.appendAscii.

Yeah, that's probably the best route.

However there's a little bug in the new Dbg_SbxDataType2String impl, the
old one had...

String aRet( RTL_CONSTASCII_USTRINGPARAM("Unknown Sbx-Type!") );
...
aRet = something
...
return aRet;

while the new one has...

::rtl::OUStringBuffer aRet;
aRet.appendAscii("Unknown Sbx-Type!");
...
aRet.appendAscii("something");

i.e. now its "Unknown Sbx-Type!something" instead of "something". so
that one needs fixing.

>  Another doubt i have is how can I replace String.ConvertLineEnd() ?

Hmm, I guess we'd have to add something for that, e.g. create a helper
in comphelper/inc/comphelper/string.hxx

C.