Re: [Libreoffice] [PATCH] Only accelerators in Edit popup on Windows and KDE

On Tuesday 19 of April 2011, Christian Dywan wrote:
> > Am 19.04.2011 13:35:54 schrieb Lubos Lunak:
> > I think it makes more sense to have it as a style setting rather than
> > hardcoding a bunch of if's
>
> I don't think it makes sense as a setting, and no platform has a setting
> for this afair.

 By setting I don't mean a configurable setting, but a style setting, i.e. the 
StyleSettings vcl class. There are already settings for things like palette, 
widget sizes, cursor blink time, whether to show icons in menus and other 
platform settings, so a setting for not showing accelerators in edit popups 
seems to fit there. Each platform sets the settings the way it should be for 
the platform and the code just checks the setting and doesn't care what 
platforms those are (so no if's and all the settings are in one place rather 
than scattered over the codebase).

-- 
 Lubos Lunak
 l.lunak@suse.cz