Re: [Libreoffice] [PATCH] Only accelerators in Edit popup on Windows and KDE

Jan Holesovsky <kendy -AT- suse.cz>
Fri, 15 Apr 2011 22:08:54 +0200

Hi Christian,

On 2011-04-15 at 12:48 +0000, Christian Dywan wrote:

I'm not sure if this is the best way to address this, I looked at the
style settings, but this isn't a setting, and I saw
get_desktop_session() but that isn't public API and I'm not sure how
it's meant to be used. If there's a better approach, pointers welcome.


Nice, thank you very much for the patch! :-)  The best is to use
Application::GetDesktopEnvironment(), like eg. here:

http://opengrok.libreoffice.org/xref/components/cui/source/options/optgdlg.cxx#129

[without the #ifdefs etc. - here you don't care whether the plugin is
available, or not ;-)]  Can you please update it?

Thank you,
Kendy

Context

[Libreoffice] [PATCH] Only accelerators in Edit popup on Windows and KDE · Christian Dywan
- Re: [Libreoffice] [PATCH] Only accelerators in Edit popup on Windows and KDE · Jan Holesovsky
  - Re: [Libreoffice] [PATCH] Only accelerators in Edit popup on Windows and KDE · Christian Dywan
    - Re: [Libreoffice] [PATCH] Only accelerators in Edit popup on Windows and KDE · Lubos Lunak
      - [Libreoffice] [PUSHED] Re: [PATCH] Only accelerators in Edit popup on Windows and KDE · Jan Holesovsky
- Re: [Libreoffice] [PATCH] Only accelerators in Edit popup on Windows and KDE · Lubos Lunak

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.