Re: [Libreoffice] Need a little help with the easyhack "Strip include guards in idl files"

Nuno J. Silva <nunojsilva@ist.utl.pt> writes:
> Julien Nabet <serval2412@yahoo.fr> writes:
>
> > Then I took a look at the directory "ure/offapi". There are about 3700
> > files and the strip-guards script lets a lot (more than 3000!) of
> > "#ifndef" with "#include".( I don't know why, a pb of Unix/Dos
> > end-of-line perhaps ?)
> > This time it's too much to do it manually.
> > Some idea to improve the strip-guards script ?
>
> I looked at your commit with the manually fixed guards[1] and at least
> some of these are explainable. Maybe that's why there are so many guards
> left in offapi:
>
> [1] 
> http://cgit.freedesktop.org/libreoffice/ure/commit/?id=cab76775a72e2e9e6cd242bbf87dd23475999164
[..]
> - Some guards are written with lower case, while they're defined in
>   upper case in the included file, like
>  
>    #ifndef __com_sun_star_bridge_XBridge_idl__
>    #include <com/sun/star/bridge/XBridge.idl>
>
>   while the file does
>
>    #define _COM_SUN_STAR_BRIDGE_XBRIDGE_IDL_ 

... but of course here the issue is not only upper case, but also
missing underscores.

-- 
Nuno J. Silva (aka njsg)
gopher://sdf-eu.org/1/users/njsg