Re: [Libreoffice] -Woverloaded-virtual

On Thursday 24 of March 2011, Lubos Lunak wrote:
>  Attached is a patch for introducing the warning (quite obvious) and a list
> of warnings (duplicates removed). I don't want to enable the warning right
> now, since although I've already reduced the number of warnings, I don't
> want to enable this too soon. If somebody sees something easy in the list
> of warnings, feel free to fix it, some of them look pretty non-obvious to
> me (e.g. I have no idea if the XAccessibleEventListener vs XEventListener
> are intentional or mistakes).

 Actually, if somebody could check the warnings related to *.hdl files, I 
think it's good enough to be enabled. The remaining warnings are mostly 
confined to small places (lotuspro filter, canvas) or are small in number and 
can be fixed by whoever will feel like it.

 BTW the warnings in canvas are pretty ugly - it's a template class that 
inherits from some of its template arguments and sometimes one of those is a 
UNO interface that implements disposing(const 
com::sun::star::lang::EventObject&), whereas the class itself implements 
disposing(). Solving it by "using Base::disposing" doesn't work, since the 
template doesn't always inherit from that UNO class.

-- 
 Lubos Lunak
 l.lunak@suse.cz