On Tue, 22 Mar 2011 11:16:14 +0000 Caolán McNamara <caolanm@redhat.com> wrote:
On Mon, 2011-03-21 at 14:32 +0100, Bjoern Michaelsen wrote:Hi all, I just enabled striping on link for gbuild on Linux unless you explicitly requested symbols, by setting SYMBOL/SYMBOLS or DEBUG: http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?id=1ed2342c1e33c28ad048205c4a708fe7b39bfb17We have an --enable-symbols which sets var ENABLE_SYMBOLS (which is optionally also SMALL for -g1), would be good to align these things, so.... how about I change --enable-symbols to export "SYMBOLS" instead of "ENABLE_SYMBOLS", drop the "small" option which I think is really unused, and adapt anything using ENABLE_SYMBOLS to SYMBOLS so that --enable-symbols works out of the box for both gbuild stuff and remaining dmake using stuff.
+1 in general. Maybe we should stick with ENABLE_SYMBOLS (which is the usual configure convention) and get rid of the SYMBOL/SYMBOLS variables, although is a bit more to type when one uses "make -sr ENABLE_SYMBOLS=TRUE". Your choice. Best, Bjoern -- https://launchpad.net/~bjoern-michaelsen
Attachment:
signature.asc
Description: PGP signature