Re: [Libreoffice] [Pushed] Rewiew needed for pythonscript.py patch (new try)

Le 17/03/2011 11:41, Jan Holesovsky a écrit :
> Hi Julien,
>
> On 2011-03-14 at 13:20 +0000, Caolán McNamara wrote:
>
>    
> > > I added this because of a warning (error) with pychecker. On the
> > > contrary of the other blocks, the variable uri "wasn't" declared and
> > > initialized whereas it was used in this block.
> > >        
> > Ah, i see it now, its a use of that "uri" inside the log.debug line.
> > Indeed, if logging was turned on then replaceByName would fail due to a
> > missing uri, so its a good fix after all
> >      
> Seems to me that there are no objections [and for me after a brief look
> looks good too], so please go ahead, and push :-)
>
> Regards,
> Kendy
>    
I already had pushed it after the message of Caolan and forgot to tell i 
had.
Thank you for your review !

Julien.