Re: [Libreoffice] Rewiew needed for pythonscript.py patch (new try)

Jan Holesovsky <kendy -AT- suse.cz>
Thu, 17 Mar 2011 11:41:01 +0100

Hi Julien,

On 2011-03-14 at 13:20 +0000, Caolán McNamara wrote:

I added this because of a warning (error) with pychecker. On the
contrary of the other blocks, the variable uri "wasn't" declared and
initialized whereas it was used in this block.


Ah, i see it now, its a use of that "uri" inside the log.debug line.
Indeed, if logging was turned on then replaceByName would fail due to a
missing uri, so its a good fix after all


Seems to me that there are no objections [and for me after a brief look
looks good too], so please go ahead, and push :-)

Regards,
Kendy

Context

[Libreoffice] Rewiew needed for pythonscript.py patch (new try) · Julien Nabet
- Re: [Libreoffice] Rewiew needed for pythonscript.py patch (new try) · Christian Lohmaier
  - Re: [Libreoffice] Rewiew needed for pythonscript.py patch (new try) · Julien Nabet
    - Re: [Libreoffice] Rewiew needed for pythonscript.py patch (new try) · Caolán McNamara
      - Re: [Libreoffice] Rewiew needed for pythonscript.py patch (new try) · serv serva
        
        Re: [Libreoffice] Rewiew needed for pythonscript.py patch (new try) · Caolán McNamara
        
        Re: [Libreoffice] Rewiew needed for pythonscript.py patch (new try) · Jan Holesovsky
        
        Re: [Libreoffice] [Pushed] Rewiew needed for pythonscript.py patch (new try) · Julien Nabet

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.