Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi,

I'm having a look at your patch files. The first thing to mention is that "whitespace-only changes" should be avoided. The second thing: 12000 lines for a single patch file is too long. You should split them into pieces that reviewing a single patch can be done in a reasonable time.

You'll have to be very patient until everything is reviewed. I'll skip "whitespace only" only changes.

Christina Rossmanith

Am 08.03.2011 21:06, schrieb Xisco Faulí:
Hello,

I've been working on removing dead code in libs-core for a while ago. I'd say libs-core it's now 98-99% dead code free. I built all the modules I worked in, and everything is allright. I tried to attach the patches into a previous email but it was too big so the mailing list refused it. I copy a rar file with 25 patches in my dropbox: http://dl.dropbox.com/u/1274885/remove-dead-code.zip . I swear it's 100% virus free.

Cheers



_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.