Re: [Libreoffice] [PATCH] Gentoo patches from old build repository for master

On Mon, 07 Mar 2011 20:44:04 +0000
Caolán McNamara <caolanm@redhat.com> wrote:

> On Mon, 2011-03-07 at 19:03 +0100, Hanno Meyer-Thurow wrote:
> > 1. Do not add compiler default include and library path: potentially build
> >    against different version of system library than requested by the user
> >    (i.e., /usr/local/lib vs /usr/lib).
> >
> >     Report: http://qa.openoffice.org/issues/show_bug.cgi?id=65976
> >     Fix:            
> > http://code.google.com/p/gekis-playground/source/browse/#svn/trunk/app-office/libreoffice/files/pre/config_office-XINC-XLIB-defaults.diff
>
> Remove XLIB=`$PKG_CONFIG --variable=libdir x11` and hardcoding
> XLIB="/usr/lib" will break the 64bit multilib archs, e.g. Fedora x86_64
> which place 64bit libs into /usr/lib64 not /usr/lib

Well, that '/usr/lib' path is hard-coded in configure right now. So I may replace
it for the xinerama check, which should be properly rewritten anyway, with
`$PKG_CONFIG --variable=libdir x11`.

> > 2. Add a configure option to disable Python2 (PyUNO) bindings. Python3 is
> >    available for more than two years.
>
> This just allows disabling it right ?, not actually provides a Python3
> port ?

Yes and no port. That requires an advanced Python/C hackers ability for
some non-portable code - needs rewrite/redesign from scratch AFAICT
for Python3, at least one part.

> > 3. Fix sandbox violation in officecfg module: rm /bin/<language>.zip
> >
> >     Report: https://bugs.gentoo.org/show_bug.cgi?id=251932
> >     Fix:            
> > http://code.google.com/p/gekis-playground/source/browse/#svn/trunk/app-office/libreoffice/files/pre/gentoo-sandbox.diff
>
> Personally would prefer that code falls back to some allowed location,
> e.g. getTempDir or something, rather than hacking it out.

That is not used anymore as far as we could see. So just some cruft left.
At least for officecfg. Is there more to it?

        http://svn.services.openoffice.org/opengrok/xref/Current%20%28trunk%29/set_soenv.in#186

This is not good. Either the modules should set it or a proper default to ${TEMP} or such should be.


Thanks for the review, Caolan!


Hanno