On Thu, 2011-02-24 at 14:30 -0500, Kevin Hunter wrote:
Interesting. From a different background, I worry about _all_ input. I
don't know the API or internals well enough to say one way or the other,
but there's no (mild) security concern here? Like giving a potentially
unsanitized string to GTK, or in the replacement routines of OString?
Oh sure, feel free to add some hardening around it, e.g. checking
HasError, but instead of return 0 and skipping the showing of the
overwrite dialog and aborting the save as, instead fallback to the old
generic overwrite dialog text.
In any event, I've done as you suggested. How does this round of the
patch work?
Looks good to me, pushed.
C.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.