Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index 

At 11:30am -0500 Thu, 24 Feb 2011, Caolán Mcnamara wrote:

On Thu, 2011-02-24 at 09:57 -0500, Kevin Hunter wrote:

please do spit it back to me with, "you should implement it this
way instead"



c) I wouldn't bother with the aFileObj.HasError() and return 0, i.e.
I'd prefer to get some mangled/empty string as the filename listed in
the overwrite dialog, rather than returning out of the whole method
on failure
Interesting. From a different background, I worry about _all_ input. I don't know the API or internals well enough to say one way or the other, but there's no (mild) security concern here? Like giving a potentially unsanitized string to GTK, or in the replacement routines of OString?
In any event, I've done as you suggested. How does this round of the patch work? 

Thanks,

Kevin

Attachment: 0001-Fix-GTK-dialog-replacement-of-filename.patch.gz
Description: GNU Zip compressed data

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.