Re: [Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc

Bjoern Michaelsen <bjoern.michaelsen -AT- canonical.com>
Thu, 24 Feb 2011 16:45:05 +0100

Hi, 

On Thu, 24 Feb 2011 15:30:45 +0000
Caolán McNamara <caolanm@redhat.com> wrote:

On Thu, 2011-02-24 at 10:11 -0500, Kohei Yoshida wrote:

On Thu, 2011-02-24 at 15:26 +0100, Julien Nabet wrote:

2) must we remove all the "rtl::" stuff ?

-using namespace rtl;
which looks fine,

+1

+using ::rtl::OUString 
which looks fine when necessary to make it possible to compile a file
which used to have "using namespace rtl;"

+1

-rtl::OUString
+OUString
which would be unnecessary, and likely cause a huge amount of churn,
no ?

Right. Those should be left as is, as being a little more explicit does
not hurt, esp. since it does not impact readability.

Best Regards,

Bjoern

-- 
https://launchpad.net/~bjoern-michaelsen

Context

[Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc · Julien Nabet
- Re: [Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc · Kohei Yoshida
  - Re: [Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc · Caolán McNamara
    - Re: [Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc · Bjoern Michaelsen
    - Re: [Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc · Kohei Yoshida
      - Re: [Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc · Bjoern Michaelsen

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.