On Thu, 2011-02-24 at 10:11 -0500, Kohei Yoshida wrote:
On Thu, 2011-02-24 at 15:26 +0100, Julien Nabet wrote:
2) must we remove all the "rtl::" stuff ?
If you mean "using namespace rtl;", yes, because that could cause
conflict between com::sun::star::uno::Reference and rtl::Reference. I
prefer we don't have any of those lines in our code base.
Just to clarify here, and looking at the patch. The goal is to remove
"using namespace rtl;", right ?
not to remove rtl:: off the front of everything.
i.e. in the attached patch I see
-using namespace rtl;
which looks fine,
and I see various
+using ::rtl::OUString
which looks fine when necessary to make it possible to compile a file
which used to have "using namespace rtl;" and uses bare "OUString"
without making vast amounts of changes.
but I see some
-rtl::OUString
+OUString
which would be unnecessary, and likely cause a huge amount of churn,
no ?
C.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.