On Thu, Feb 17, 2011 at 6:06 PM, Jan Holesovsky <kendy@suse.cz> wrote:
Hi Rafael, Rafael Dominguez píše v Ne 13. 02. 2011 v 23:40 +0000:Well the patch is related to sw, tab entries in Insert->Indexes and Tables -> Indexes and Tables.Wow - if I am not mistaken, this is your first LibreOffice patch, and already quite a lot of work, thank you for that! :-) I updated few pieces in your patch, and pushed that to master: http://cgit.freedesktop.org/libreoffice/writer/commit/?id=da916c2962cdbaec95477f83f2729951bc0f5e5c If you can test with the updated version, that would be great. Can you please confirm that your contribution is LGPLv3+/MPL? The main thing that I changed was that in some cases you used vector<...>::iterator it = another_iterator + 1; This is not correct, operator+() is not defined on std::vector, so the result might be not what you'd expect; similarly with -1. I have changed those to ++it, or --it (on a temporary copy, or so). Other than that - very nice cleanup, looking forward to more! :-) All the best, Kendy
Well since someone suggested to change it to boost::ptr_vector, i made a new patch i didnt expect to get pushed this fast, also fixed a small bug i had. All the patch is LGPLv3+/MPL ^^
Attachment:
0001-Remove-DECLARE_LIST-TOXControlList-Control.writer.patch
Description: Binary data