Hi Rafael,
Rafael Dominguez píše v Ne 13. 02. 2011 v 23:40 +0000:
Well the patch is related to sw, tab entries in Insert->Indexes and
Tables -> Indexes and Tables.
Wow - if I am not mistaken, this is your first LibreOffice patch, and
already quite a lot of work, thank you for that! :-) I updated few
pieces in your patch, and pushed that to master:
http://cgit.freedesktop.org/libreoffice/writer/commit/?id=da916c2962cdbaec95477f83f2729951bc0f5e5c
If you can test with the updated version, that would be great.
Can you please confirm that your contribution is LGPLv3+/MPL?
The main thing that I changed was that in some cases you used
vector<...>::iterator it = another_iterator + 1; This is not correct,
operator+() is not defined on std::vector, so the result might be not
what you'd expect; similarly with -1. I have changed those to ++it, or
--it (on a temporary copy, or so).
Other than that - very nice cleanup, looking forward to more! :-)
All the best,
Kendy
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.