Re: [Libreoffice] re-enable icons on Linux for KDE

On Wednesday 09 of February 2011, Michael Meeks wrote:
> On Tue, 2011-02-08 at 20:43 +0100, Lubos Lunak wrote:
> > On Sunday 06 of February 2011, Michael Meeks wrote:
> > >   Right ;-) they should all be built, and delivered into the solver, but
> > > only the ones you specify should be bundled
> >
> >  Does that mean you have broken KDE integration with that change :) ?
>
>       Oh ! yes, quite right - we should revert that for Linux, my fault - I
> got over-enthusiastic about shrinking somehow. Do we really need both
> CRYSTAL and OXYGEN (for kde3 and kde4 ?).

 Crystal is for KDE3, Oxygen is for KDE4, and I think each is (more or less) 
needed for its KDE version integration.

> Anyhow - patch to do that appended for review for the dev branch. At least
> we dropped the classic theme.
>
> diff --git a/distro-configs/LibreOfficeLinux.conf.in
> b/distro-configs/LibreOfficeLinux.conf.in index f55c19b..210ba3e 100644
> --- a/distro-configs/LibreOfficeLinux.conf.in
> +++ b/distro-configs/LibreOfficeLinux.conf.in
> @@ -56,4 +56,4 @@
>  --disable-kde4
>  --disable-dbus
>  --disable-crypt-link
> ---with-theme=\"default hicontrast tango\"
> +--with-theme=\"default hicontrast tango oxygen crystal\"

 Hmm, how does this actually work? This file has --disable-kde4 
(and --disable-kde too I presume, I can't actually find this file anywhere), 
so there the option seems appropriate the way it is.

 If this file affects the defaults somehow, then I'd only change --enable-kde 
and --enable-kde4 to add their icon set to the list if necessary.

-- 
 Lubos Lunak
 l.lunak@suse.cz