Re: [Libreoffice] [PUSHED] Re: SmNodeToTextVisitor Fixes

Hello Jonas, Michael, list,

Sorry for not replying sooner.

On Tue, 2011-02-01 at 19:32 +0100, Jonas Finnemann Jensen wrote:
> I don't think it's critial... None of the commits that removes
> brackets and improves SmNodeToTextVisitor have been applied to
> libreoffice-3-3... The SmNodeToTextVisitor there uses a lot of
> brackets, so there's hopefully no major issues with it...

I guess I'm too late now, so maybe for 3.3.2, but maybe there are a
couple of bugs that could be fixed for libreoffice-3-3.
We could fix two of the bugs, 32759 and 32755 on the freedesktop.org
bugzilla, as they are quite simple and seem to be a fixable by removing
one character and one line (which is how it is now on master now). It
seems so simple I wonder if I'm missing something about these two?

Other than that I think Jonas is right.

Regards,
Luke

From 37084a642a789a1788783c0a3db708396e16197a Mon Sep 17 00:00:00 2001
From: Luke Dixon <6b8b4567@gmail.com>
Date: Tue, 8 Feb 2011 20:15:21 +0000
Subject: [PATCH] Fix for bugs 32759 and 32755 on freedesktop bugzilla

---
 starmath/source/visitors.cxx |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/starmath/source/visitors.cxx b/starmath/source/visitors.cxx
index dc5dd38..7b7dafe 100644
--- a/starmath/source/visitors.cxx
+++ b/starmath/source/visitors.cxx
@@ -2131,7 +2131,7 @@ void SmNodeToTextVisitor::Visit( SmTableNode* pNode )
             LineToText( it.Current( ) );
             if( it.Next( ) ) {
                 Separate( );
-                Append( "## " );
+                Append( "# " );
             }else
                 break;
         }
@@ -2447,7 +2447,6 @@ void SmNodeToTextVisitor::Visit( SmTextNode* pNode )
 
 void SmNodeToTextVisitor::Visit( SmSpecialNode* pNode )
 {
-    Append( "%" );
     Append( pNode->GetToken( ).aText );
 }
 
-- 
1.7.4