Re: [Libreoffice] [PATCH] [PUSHED] DBG_ASSERT -> OSL_ENSURE (dbaccess)

On Thu, Feb 03, 2011 at 01:41:19AM -0700, Tor Lillqvist wrote:
> > Thanks. In addition, I changed several
> > #ifdef DBG_UTIL
> > lines enclosing declarations of variables/functions accessed in the
> > debug macros to
> > #if OSL_DEBUG_LEVEL > 0
>
> Is that something we can/should do in general everywhere? What about the #ifdef PRODUCT things, 
> can those too be #if OSL_DEBUG_LEVEL>0 ?

That should be #if OSL_DEBUG_LEVEL == 0, i.e., PRODUCT implies no
debugging.

> (Sounds like a potentially good idea to me; I never fully understood the logic of having the 
> separate "product" vs. "non-product" build dichotomy, and the one time I tried a "non-product" 
> build it failed miserably anyway.)

Actually, there is a bit more to it than just product/non-product :)
Like "compact" builds (whatever that means), profiling builds, etc.;
just search for "Produkt auf einen Wert setzen" and "Pfade setzen" in
solenv/inc/settings.mk . I suspect that stuff has been unusable for
years and can be removed safely...

> If we do this, can we then get rid of the ".pro" sufffix on the build directories, too, please?

I started on that at some point in the past, but left it unfinished.
Maybe I'll do it this weekend, if I feel like it :)

D.