Hi Dave,
On Mon, 2011-01-31 at 10:21 -0800, Dave Dumaresq wrote:
Thanks for the update!
Just pushed a fix; the unfortunate random re-use of poorly scoped local
variables made this hard to see in the patch. IMHO we need to be locally
scoping all variables as tightly as possible when we touch code.
Anyhow; the problem luckily showed in valgrind:
==17596== Conditional jump or move depends on uninitialised value(s)
==17596== at 0x8086F49: RscTypCont::PutSysName(unsigned long, char*,
unsigned long, unsigned long, unsigned char) (rscdb.cxx:388)
==17596== at 0x8086F49: RscTypCont::PutSysName(unsigned long, char*,
unsigned long, unsigned long, unsigned char) (rscdb.cxx:388)
==17596== by 0x8070B4F: RscSysDepend::WriteSysDependRc(RSCINST
const&, RscWriteRc&, RscTypCont*, unsigned long, unsigned char, unsigned
char) (rscclass.cxx:1095)
==17596== by 0x8070B4F: RscSysDepend::WriteSysDependRc(RSCINST
const&, RscWriteRc&, RscTypCont*, unsigned long, unsigned char, unsigned
char) (rscclass.cxx:1095)
HTH,
Michael.
--
michael.meeks@novell.com <><, Pseudo Engineer, itinerant idiot
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.