Hi Cedric,
I guess you are right. Keeping the code in there, even if only temporarily,
might not make much sense.
If it's ok to remove the functions from the unused list directly I'm happy to do
that. I was a bit concerned because some of those functions might be required at
some point.
In most cases they are just member functions (overloaded or not) that are not
being used right now, but that doesn't mean that they might not be useful at
some point.
I will change my patch and adapt it to remove the code, rather than comment it
out.
Regards,
Alfonso
Hi Alfonso,
On Sat, 2011-01-29 at 15:10 +0000, Alfonso Eusebio wrote:
Hi,
I've been going through the list of identified unused functions in calc and
commenting out those that don't seem to be used anywhere.
Why don't you simply remove them and check if it still builds?
Regards,
--
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr
Context
- Re: [Libreoffice] [PATCH] Commented out some unused functions in calc · Alfonso Eusebio
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.