Re: [Libreoffice] [PATCH] EasyHacks 4.13 - get rid of macros from svarray.hxx

On Fri, 2011-01-28 at 17:03 +0000, Nigel Hawkins wrote:
> On Fri, 2011-01-28 at 10:50 -0500, Kohei Yoshida wrote:
> > Here, you've changed the semantics of the code.  I've fixed that to
> > push_back(nTab+i) which is probably what we need to do here.
>
> Sorry. My bad.

Not a problem.  I eventually caught it, so it's all good. ;-)

> > Your second patch is pretty small & reasonable.  It should be okay as
> > the only other places where SvShorts is used is in binfilter, and
> > binfilter itself contains its own SvShorts declaration.
>
> Completely missed that. I don't usually build binfilter as it isn't
> built by default (I think).
>
> Also, binfilter doesn't appear to be indexed by the OpenGrok search
> tool. Which seems odd (and is the main reason I missed it).

Ah. Ok.  I think Cedric could probably tell us the real reason (CC'ed),
but I'm pretty sure it was intentionally skipped since not many people
care about binfilter for the most part.

Another useful way to hunt for usage of certain classes, macros etc, is
to use git grep "keyword".  Using it via the 'g' script

/g grep "keyword"

will give you rough ideas of where certain things are referenced across
all repositories, including binfilter.

> Looking at it now, binfilter seems to have almost a complete duplicate
> of all the svarray stuff. Do we know why it doesn't use the "standard"
> ones?

Good question.  I think it was duplicated in order to shield itself from
depending on other modules.  Binfilter represents a snapshot of what
some parts of the OOo/LibO code base used to be, so you will see a lot
of duplications there but frozen in time, and SvShorts is no exception
apparently.

HTH,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>