Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


On Fri, 2011-01-28 at 10:50 -0500, Kohei Yoshida wrote:
Here, you've changed the semantics of the code.  I've fixed that to
push_back(nTab+i) which is probably what we need to do here.

Sorry. My bad.

Your second patch is pretty small & reasonable.  It should be okay as
the only other places where SvShorts is used is in binfilter, and
binfilter itself contains its own SvShorts declaration.

Completely missed that. I don't usually build binfilter as it isn't
built by default (I think).

Also, binfilter doesn't appear to be indexed by the OpenGrok search
tool. Which seems odd (and is the main reason I missed it).

Looking at it now, binfilter seems to have almost a complete duplicate
of all the svarray stuff. Do we know why it doesn't use the "standard"
ones?

Nigel.

----------
NEW Zoner Photo Studio Free - is a free program for every step in the process
of managing, editing, and sharing pictures.  --- freephotostudio.com 

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.