Re: [Libreoffice] Patches by two persons?

On Thu, 2011-01-27 at 17:51 +0100, Miklos Vajna wrote:
> > Until now we have committed the patches, by me committing them, but as
> > it seems we are doing a lot of patches, it would be nice to know what
> > is the preferred way to do it:
> > - Should we put both our names in the git patch file (this is easy to do)?
> > - Should we just use one of our email addresses for the git patch
> > file, or is it preferably to make a common email address for this
> > purpose?
> > - Should just one of us send the patches to the mailing list, or
> > should we do this from a common email address?
>
> Yep, if you put both names in the commit message, that should do it, I
> think. The From of the mail in which you send the patch as an
> attachment is not really important - and creating a new email address
> just for this purpose sounds an overkill.

Well, we may need to adapt the tools computing the stats and credits to
take this into account. We will need to get all the names pretty easily
from git to get everyone properly thanked. Isn't the sign-off way the
best one?

Regards,
-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr