Hello,
this declaration seems to not be used.
A similar one exists in the file token.cxx in formula/ where this was
copied from according to the comments.
This, in combination with some toolchain issue I guess caused regcomp
crashing on Ubuntu armel at the install phase.
From what I gathered so far the FixedMemPool destructor for the first
instance (in formula's token.cxx) was overwritten by the destructor in
sc's token.cxx.
When running these destructors in regcomp's atexit/fini, the formula one
was never called, while the sc one was called twice resulting in the
segfault.
This only occured if the registry file was not already there, in which
case there was no crash but arena tracing printed out bad memory anyway.
I don't know if this was the case for other arch's as well and they were
just lucky in avoiding the segfault, or it's an armel toolchain issue at
play as well.
Jani
From 7305b53aad89f4c0362e6126edc8f1930eed22f4 Mon Sep 17 00:00:00 2001
From: Jani Monoses <jani.monoses@canonical.com>
Date: Thu, 27 Jan 2011 15:33:06 +0200
Subject: [PATCH] Remove unused declaration
---
sc/source/core/tool/token.cxx | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx
index 3298517..48021b1 100644
--- a/sc/source/core/tool/token.cxx
+++ b/sc/source/core/tool/token.cxx
@@ -110,9 +110,6 @@ namespace
//
} // namespace
//
-// ImpTokenIterator wird je Interpreter angelegt, mehrfache auch durch
-// SubCode via FormulaTokenIterator Push/Pop moeglich
-IMPL_FIXEDMEMPOOL_NEWDEL( ImpTokenIterator, 32, 16 )
// Align MemPools on 4k boundaries - 64 bytes (4k is a MUST for OS/2)
--
1.7.2.3
Context
- [Libreoffice] [PATCH] remove unused declaration - an unlikely fix for armel segfault in regcomp · Jani Monoses
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.