Re: [Libreoffice] [PATCH] g warper: forcing the recreation of symlinks

On Wed, Jan 19, 2011 at 4:36 PM, Bircher Florian <florian.bi@gmx.net> wrote:
> for cygwin -e check seems to check if the "target of the symlink"
> exists, not the symlink ifself...
> But there is a error in the script that this function gets called in the
> main repro (bootstrap) ... and create symlinks like "ln -s test test".

ahh, yes: once upon a time bootstrap was a cloned git repo like the
other... but now there is no need for links since the dubsdirectory of
bootstrap are already there.
in this case you want to exclude the case where REPO='bootstrap"
around for for link $(ls) loop

Norbert


> I will create a new patch.
>
>
> Am 19.01.2011 23:03, schrieb Norbert Thiebaud:
> > Ok, I'm confused:
> >
> > +++ b/g
> > @@ -237,7 +237,7 @@ for REPO in $DIRS ; do
> >                      for link in $(ls) ; do
> >                          if [ ! -e "$RAWBUILDDIR/$link" ] ; then
> >
> > If "$RAWBUILDDIR/$link" does not exist, why would you need to 'force'
> > the creation of the link ?
> >
> > maybe you want
> >                          if [ ! -e "$RAWBUILDDIR/$link/." ] ; then
> > instead... just in case a dangling link pass the -e test on windows...
> >
> >                              echo "Creating missing link $link"
> > -                            ln -s "$DIR/$link" "$RAWBUILDDIR/$link"
> > +                            ln -sf "$DIR/$link" "$RAWBUILDDIR/$link"
> >                          fi
> >                      done
> >                      ;;
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice