Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


On Tuesday 18 of January 2011, Kohei Yoshida wrote:
I am a bit tempted to make calling of EarlyCommandLineArgsPrepare()
platform independent just so that we can remove that #ifdef UNX guard
around it.  Is there any objection for doing so? :-)

 Not from me, but the cli arguments handling was #ifdef UNX even before my 
patch for whatever reason, and I don't know the reason.

Since the 
application service manager must be created at some point during the
startup, I don't think creating it early would impact startup
performance or cause any other issues.  The only thing I may be
concerned about is some weird crash-on-exit bug that depends on the
order of creation of global static objects...

 I think the change shouldn't change anything in this regard, as it's simply 
moving the creation forward in code that's irrelevant for it, but I'm not 
familiar with those areas of LO yet, so I can't say for sure.

-- 
 Lubos Lunak
 l.lunak@suse.cz

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.