Re: [Libreoffice] [REVIEW] Make --help and --version work even without $DISPLAY

On Tue, 2011-01-18 at 19:38 +0100, Lubos Lunak wrote:
> Hello,
>
>  could somebody please review the attached patch? While digging for something 
> else I noticed that --version doesn't work without $DISPLAY, recalled seeing 
> a bugreport about that somewhere [*] and thought how hard that could be (oh, 
> silly me). I swear this is the simplest and safest patch I've managed to come 
> up with :-/, but since it still moves around initialization of some stuff, 
> I'd like somebody else to check. Thanks.

Ok.  I may not be the most knowledgeable in this area, but I've modified
this area several times recently, so I guess I qualify to review your
patch.

The patch looks good to me, and I pushed it on master.  Now the soffice
feels a bit snappier when --help or --version given at the command line.

I am a bit tempted to make calling of EarlyCommandLineArgsPrepare()
platform independent just so that we can remove that #ifdef UNX guard
around it.  Is there any objection for doing so? :-)  Since the
application service manager must be created at some point during the
startup, I don't think creating it early would impact startup
performance or cause any other issues.  The only thing I may be
concerned about is some weird crash-on-exit bug that depends on the
order of creation of global static objects...

> [*] Speaking of the bugreport, does it ring a bell to somebody? I can't find 
> it now.

You mean this one?
https://bugzilla.novell.com/show_bug.cgi?id=332222

I marked it fixed recently, but I guess I didn't fix it correctly wrt
the DISPLAY setting. ;-)  Thanks a lot for the right fix.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>