Re: [Libreoffice] Splitting up source/header files for clarity

I have now splitted the implementation of funcdesc.hxx out into a new
source file funcdesc.cxx. In the process I also have extracted two new
header files for classes previously defined in global.cxx. I have
corrected all includes and the result compiles for me, I have added
the new source file to the relevant makefile.mk. Further I have added
comments to the first class in funcdesc.hxx, I hope to document the
others in a later patch. Please review my patch and apply if ok.

Best Regards
Sören Möller
(LGPLv3+ / MPL)

2011/1/10 Tor Lillqvist <tlillqvist@novell.com>:
> > - Is it best to make one file for each class, or keep them together
> > and make one funcdesc.cxx (containing four classes)?
>
> I'd say one file, funcdesc.cxx, corresponding to funcdesc.hxx. But that is just my personal 
> opinion.
>
> > - Should the license header for the new file(s) be a copy of the
> > license header from global.cxx (as the code is copied out), or the new
> > Libo header?
>
> As the code is the same (just rearranged into different files), the license header should be the 
> same.
>
> > - Is it enough to add the new file(s) to
> > sc/source/core/data/makefile.mk for building,
>
> Yes, that should be enough for your testing; if/when you then want to make a patch out of it, you 
> need to git add the new files to your local repository clone.)
>
> --tml