Hi
I have been working with sc/inc/funcdesc.hxx, and this header defines
four closely related classes, but all the implementation of these
classes is in sc/source/core/data/global.cxx together with the
implementation of a number of other classes. This makes it confusing
to find the implementations and check these classes separately, so it
would be nice to have these implementations in their own file/files.
This is even suggested by a comment in sc/inc/funcdesc.hxx which
sounds, as if the header earlier was part of some huge file too.
Moving these implementations to own files raises some questions:
- Is it best to make one file for each class, or keep them together
and make one funcdesc.cxx (containing four classes)?
- Should the license header for the new file(s) be a copy of the
license header from global.cxx (as the code is copied out), or the new
Libo header?
- Is it enough to add the new file(s) to
sc/source/core/data/makefile.mk for building, or have they to be added
somewhere else too?
Any comments are appreciated
Best Regards
Sören Möller
Context
- [Libreoffice] Splitting up source/header files for clarity · Soeren Moeller
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.