Re: [Libreoffice] [PATCH] [PUSHED] new cppcheck cleaning in svx

On Fri, Dec 31, 2010 at 03:04:29PM +0100, Julien Nabet wrote:
> Hello,
>
> Here is a new patch for cppcheck cleaning in svx
> Compiling was ok
>
> I have no more this pb :
> [./svdotxln.cxx:67]: (style) The class 'ImpSdrObjTextLink' does not
> have a constructor.
>
> Julien
> (LGPLv3+ / MPL)

> commit 2441e55a06e314cf1876bee1809c7846f260087a
> Author: Julien Nabet <serval2412@yahoo.fr>
> Date:   Fri Dec 31 14:59:47 2010 +0100
>
>     cppcheck cleaning
>
> diff --git a/svx/source/accessibility/AccessibleShape.cxx 
> b/svx/source/accessibility/AccessibleShape.cxx
> index 1b2577a..8f7fddf 100644
> --- a/svx/source/accessibility/AccessibleShape.cxx
> +++ b/svx/source/accessibility/AccessibleShape.cxx
> @@ -513,7 +513,7 @@ awt::Rectangle SAL_CALL AccessibleShape::getBounds (void)
>                          aValue >>= aBoundingBox;
>                          bFoundBoundRect = true;
>                      }
> -                    catch (beans::UnknownPropertyException e)
> +                    catch (beans::UnknownPropertyException &e)

I changed these from

catch (SomeException& e)

to

catch (SomeException const& e)

and removed the parameter name where it clearly was not used in the
catch block.

D.