On Thu, Dec 30, 2010 at 06:43:12PM +0100, Julien Nabet wrote:
Hello,
Here is a patch for cppcheck cleaning in vcl
Compiling was ok.
I'm not sure if what I did about realloc pb in the file :
vcl/unx/source/gdi/xlfd_attr.cxx
was sufficient (even correct !).
If Enlarge() failed, Insert() silently returns whatever value
mnLastmatch happened to be, that means that you replaced possible
segfault with possible wrong behaviour :( IMHO the right thing here is
to throw std::bad_alloc if the reallocation failed and I changed the
patch accordingly.
D.
Context
- Re: [Libreoffice] [PATCH] [PUSHED] cppcheck cleaning in vcl · David Tardon
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.