On Thu, 2010-12-30 at 13:23 -0200, Kayo Hamid wrote:
So, it's a small patch that I send for review because I do not know if
it's ok to do what the cppcheck says to do. In this case, he says that
for non-primitive types we can do ++test instead test++. My fear is if
in the code really need to be test++, understand?
In those use cases it makes no difference whether it's a post- or
pre-increment. It matters only when its return value is stored & used.
I pushed your patch to master.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>
Context
- Re: [Libreoffice] [PATCH] [PUSHED] cppcheck at writer, performance. · Kohei Yoshida
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.