On Mon, 2011-01-03 at 21:47 +0100, Soeren Moeller wrote:
Hi
I have removed dependencies on tools/solar.h in some files in sc
(according to http://wiki.documentfoundation.org/Easy_Hacks#write_tools.2F_pieces_out
) please review and commit.
Thanks, pushed!
BTW, we generally prefer the standard bool over sal_Bool, so I replaced
sal_Bool with bool in your patch. The only place we need to use
sal_Bool is when dealing with the UNO API. Other than that, the
standard boolean type is preferred.
Also, it's a bit weird to use sal_uIntPtr which isn't used much in our
code base. So I replaced that with sal_uInt32.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.