So, it's a small patch that I send for review because I do not know if
it's ok to do what the cppcheck says to do. In this case, he says that
for non-primitive types we can do ++test instead test++. My fear is if
in the code really need to be test++, understand?
revol_
diff --git a/sw/source/ui/index/cntex.cxx b/sw/source/ui/index/cntex.cxx
index 2b858e3..bcca510 100644
--- a/sw/source/ui/index/cntex.cxx
+++ b/sw/source/ui/index/cntex.cxx
@@ -423,7 +423,7 @@ void SwMultiTOXTabDialog::CreateOrUpdateExample(
pValues[nTokenIndex] = aPropVals;
nTokenIndex++;
- aIt++; // #i24377#
+ ++aIt; // #i24377#
}
aSequPropVals.realloc(nTokenIndex);
diff --git a/sw/source/ui/index/cnttab.cxx b/sw/source/ui/index/cnttab.cxx
index 24bd655..4b2b4c9 100644
--- a/sw/source/ui/index/cnttab.cxx
+++ b/sw/source/ui/index/cnttab.cxx
@@ -2497,7 +2497,7 @@ IMPL_LINK(SwTOXEntryTabPage, LevelHdl, SvTreeListBox*, pBox)
aAuthFieldsLB.RemoveEntry(nLstBoxPos);
}
- aIt++; // #i21237#
+ ++aIt; // #i21237#
}
aAuthFieldsLB.SelectEntryPos(0);
}
@@ -2916,7 +2916,7 @@ void SwTokenWindow::SetForm(SwForm& rForm, sal_uInt16 nL)
bLastWasText = sal_False;
}
- aIt++; // #i21237#
+ ++aIt; // #i21237#
}
if(!bLastWasText)
{
diff --git a/sw/source/ui/misc/redlndlg.cxx b/sw/source/ui/misc/redlndlg.cxx
index 0169751..2752bbf 100644
--- a/sw/source/ui/misc/redlndlg.cxx
+++ b/sw/source/ui/misc/redlndlg.cxx
@@ -861,7 +861,7 @@ void SwRedlineAcceptDlg::CallAcceptReject( BOOL bSelect, BOOL bAccept )
ListBoxEntries_t::iterator aEnd = aRedlines.end();
for( ListBoxEntries_t::iterator aIter = aRedlines.begin();
aIter != aEnd;
- aIter++ )
+ ++aIter )
{
USHORT nPosition = GetRedlinePos( **aIter );
if( nPosition != USHRT_MAX )
Context
- [Libreoffice] [PATCH] cppcheck at writer, performance. · Kayo Hamid
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.