Re: [Libreoffice] [PUSHED] Re: SmNodeToTextVisitor Fixes

Hi Luke,

> I realized it would be possible to just have brackets in the SmExpressionNode Visitor.
That's not all true... I added all the brackets initially because I
had some problems with a few isolated things...
Try writing binom a b + c in the command text field... Then enter
visual editor an move as much to the right as possible, e.g. the
rightmost position in the toplevel line, and write + d
Now "+d" will be in the toplevel line... But if you enter the command
text editor and changes c to e, then +d will be in the second line of
the binom...
I don't think this is parsing error... But an unpleasant obscurity in
the format... I'm not even sure I fixed this one with my excessive use
of brackets... But the issue is there now... We should probably fix it
and add a unit test for it to avoid regressions...
The problem is that when binom has these obscurities maybe some of the
other command have similar obscurities... :(

Btw, you latest patch didn't introduce this issue... So it's probably
been there for a while...

> Oh, another thing I noticed was that there seems to be a crash when
> moving to the right of an SmPlaceNode and deleting it
Interesting... I've had that bug once, but I've never been able to
reproduce it... Can't this time either... Do you have any more
specific steps ?

> Anyway, some other stuff, I noticed something else while looking around
> and noticed what seemed to me to be a better place to deal with the
> percent sign.
Looks good to me... It doesn't hurt to have clean code :)
 - Really nice work... I've pushed both patches...

--
Regards Jonas Finnemann Jensen.

On Wed, Dec 8, 2010 at 02:25, Luke Dixon <6b8b4567@gmail.com> wrote:
> Hello Jonas,
>
> > By the way, is the SmNodeToTextVisitor as good as it gets now?
> > Or is it possible to do more improvements ? and if so, should we leave
> > as an easy hack we or someone can pickup later? (if not lets remove it
> > from the wiki).
> > I don't know how good it is with regards to minimizing the use of
> > brackets. E.g. if it's realistic to do it any better...
>
> I'm very sorry for stretching this out so long. I've played a little
> more with this and I'm not sure I'm really getting anywhere. I realized
> it would be possible to just have brackets in the SmExpressionNode
> Visitor. It seems to work okay to me, but maybe there will be other
> problems caused by this as I haven't been able to work out why some of
> the extra brackets were there. I don't know what you would think about
> this?
>
> Anyway, some other stuff, I noticed something else while looking around
> and noticed what seemed to me to be a better place to deal with the
> percent sign. Again, I'm not sure if I've found the right place to deal
> with this, but it seemed better to deal with it like this rather than in
> SmNodeToTextVisitor.
> I guess that as I came across this while looking at SmNodeToTextVisitor
> I thought it could be solved there.
>
> Oh, another thing I noticed was that there seems to be a crash when
> moving to the right of an SmPlaceNode and deleting it. It would be very
> easy to patch the symptoms of this in SmCursor::AnnotateSelection, but I
> guess that it would be better to work out what is going wrong. I haven't
> worked it out yet, but I thought it would be best to mention it.
>
> Sorry, for so much in one email.
>
> Regards,
> Luke