Re: [Libreoffice] [PUSHED] Re: SmNodeToTextVisitor Fixes

Hello Caolán,

> I suggest you cut and paste the header from
> http://www.freedesktop.org/wiki/Software/LibreOffice/LicenseHeader
> into the top of that new file and stick your name in there as the
> original contributor as it is new code.

Thanks, that means a lot to me. I've attached a patch which does this.
Though I must mention that I had copied the test you had added and just
changed some bits.

> As an aside, in the test_starmath.cxx I hope to make it a cppunit
> build-time test equivalent testautomation/math/required/ and enable it
> to be built and executed on all platforms. I've been struggling a little
> bit with converting tests from
> testautomation/math/required/includes/m_002_.inc e.g. tmEditMarker into
> a build-time cppunit test given the dependencies that SmEditWindow has
> on basically a fully functioning Office environment, which I want to
> avoid. Easiest thing I'm now thinking is to tweak SmEditWindow itself to
> make it standlone testable.

Unfortunately I think I've jumped in a bit too deep here.
Looking at SmEditWindow it seems to depend on quite a bit of stuff that
I don't understand. I think that you are right about tweaking it so it
doesn't depend on these though, trying to fake the other parts would be
a nightmare.
I would offer to help, but I don't think I would know where to begin.
I'm very sorry.

Regards,
Luke

From 79c433a9735346329c5cd812ce63cb2a5d8d3707 Mon Sep 17 00:00:00 2001
From: Luke Dixon <6b8b4567@gmail.com>
Date: Thu, 25 Nov 2010 14:26:18 +0000
Subject: [PATCH] Add license header to test_nodetotextvisitors.cxx

---
 starmath/qa/cppunit/test_nodetotextvisitors.cxx |   26 +++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)

diff --git a/starmath/qa/cppunit/test_nodetotextvisitors.cxx 
b/starmath/qa/cppunit/test_nodetotextvisitors.cxx
index cd8aee0..45386d1 100644
--- a/starmath/qa/cppunit/test_nodetotextvisitors.cxx
+++ b/starmath/qa/cppunit/test_nodetotextvisitors.cxx
@@ -1,4 +1,30 @@
 /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * Version: MPL 1.1 / GPLv3+ / LGPLv3+
+ *
+ * The contents of this file are subject to the Mozilla Public License Version
+ * 1.1 (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * http://www.mozilla.org/MPL/
+ *
+ * Software distributed under the License is distributed on an "AS IS" basis,
+ * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
+ * for the specific language governing rights and limitations under the
+ * License.
+ *
+ * The Initial Developer of the Original Code is
+ *       Luke Dixon <6b8b4567@gmail.com>
+ * Portions created by the Initial Developer are Copyright (C) 2010 the
+ * Initial Developer. All Rights Reserved.
+ *
+ * Contributor(s):
+ *
+ * Alternatively, the contents of this file may be used under the terms of
+ * either the GNU General Public License Version 3 or later (the "GPLv3+"), or
+ * the GNU Lesser General Public License Version 3 or later (the "LGPLv3+"),
+ * in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
+ * instead of those above.
+ */
 
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_starmath.hxx"
-- 
1.7.3.2