Noel Power wrote:
b) I also made some changes [one change I made was in ImpCurrencyToString
...]
so I think it makes sense for me to
create the feature branch ( I will do that today )
Understandable, I apologize that I did not separate the core Currency
changes from the string handling 'upgrade'.
c) there are some issues to do with stream handling that need
addressing and at least further testing ( in fact I am not even sure
that some of this stuff is needed anymore... but that is another story )
I knew the stream stuff was shaky and also felt it might hardly be used so I
submitted without any direct testing of that I/O. I am relieved that you
are looking at it.
That test program is fugly but it helped me greatly in nailing down loose
ends in the Currency scaling. I am glad it is helping you tinker with the
basic core as well.
Thanks for seriously reviewing the patch set.
--
View this message in context:
http://nabble.documentfoundation.org/PATCH-Basic-Currency-Issues-i31001-to-i107277-tp1991648p2029412.html
Sent from the Dev mailing list archive at Nabble.com.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.