Re: [Libreoffice] Suggestion needed for External Edit functionality.

Hey Thorsten ,

On Thu, Dec 2, 2010 at 1:05 PM, Thorsten Behrens
<thb@documentfoundation.org> wrote:
> I had initially intended to reply even earlier, was playing with
> your patch yesterday - sadly, there was much preemption. So here's a
> little intermezzo - great work so far, stuff looks promising!

I understand. There has been too much stuff going on RC release and
new build structure coming in. And as always thanks for the support
and encouragement :) Very grateful for your looking into my patch in
spite of the busy schedule.


> I'm pondering moving parts of extedit.cxx to svtools (there's a
> handy "misc" directory) - that way, one could reuse that from
> Impress and Calc as well. Needs a bit of tweaking here and there
> (that's what took more time yesterday than I had available) - e.g.
> hide the SwWrtShell in some opaque void pointer.

I shall touch base with you on the IRC and will implement all the
tweaks as you suggest. If there are any best practices wiki link,
please guide me to that :)

> There are one or two other things that could benefit from looking
> into, e.g. the usage of the worker thread - I think that may not be
> needed anymore, with XSystemShellExecute not blocking.

Yes, that might work as well. Should I try this and resend the patch
or should I wait for your other suggestions as well ?
Also is this the right time to apply for the FOSDEM paper or should I
wait some more time for the patch to mature ?

-- 
regards
Suren
Learning < Doing
Learn By doing.